Skip to content

Conversation

@ElliottKasoar
Copy link
Member

Resolves #373

@ElliottKasoar ElliottKasoar added the documentation Improvements or additions to documentation label Jan 13, 2025
@ElliottKasoar ElliottKasoar self-assigned this Jan 13, 2025
@ElliottKasoar ElliottKasoar marked this pull request as ready for review January 13, 2025 11:29
Copy link
Collaborator

@oerc0122 oerc0122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this should be here.

@ElliottKasoar
Copy link
Member Author

ElliottKasoar commented Jan 31, 2025

(Rebased)

@oerc0122's suggestion from recent discussions, which I agree with, is to:

  1. Merge this
  2. Open a PR with phonopy suggesting the issue is added to their troubleshooting, including similar issues e.g. CXX being unset: Add CXX installation error to troubleshooting phonopy/phonopy#511
  3. If/when that is merged, replace this text with a link to their troubleshooting

@alinelena
Copy link
Member

now is mergeed

@ElliottKasoar
Copy link
Member Author

now is mergeed

Yep, only in dev so far, so we still need to wait for it to make it into a release to appear in the docs, but hopefully that'll be pretty soon.

@ElliottKasoar
Copy link
Member Author

ElliottKasoar commented Feb 7, 2025

Rebased, and now actually links to the updated phonopy docs.

@ElliottKasoar ElliottKasoar merged commit c97046e into stfc:main Feb 12, 2025
10 checks passed
@ElliottKasoar ElliottKasoar deleted the doc-phonopy branch February 12, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document phonopy cmake error troubleshooting

3 participants